Add support for AUTH PLAIN #148
Open
+71
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corecode
requested changes
Jan 24, 2026
| free(temp); | ||
| } else if (features->auth.plain) { | ||
| // PLAIN mechanism | ||
| size_t buflen = strlen(login) + strlen(password) + 3; |
Owner
There was a problem hiding this comment.
use asprintf instead of malloc+snprintf
| /* Send AUTH command according to RFC 2554 */ | ||
| send_remote_command(fd, "AUTH LOGIN"); | ||
| const char *auth_mechanism = features->auth.login ? "LOGIN" : "PLAIN"; | ||
| send_remote_command(fd, "AUTH %s", auth_mechanism); |
Owner
There was a problem hiding this comment.
let's break out login an plain like auth_md5 into separate functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #50
I'm using dma to relay outgoing email through Oracle Cloud's smarthost service, but bumped into issue #50 due to Oracle's exclusive support for PLAIN auth.
Changes: